Skip to content

Conversation

@domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented May 22, 2025

Enabling intro_flutter_gpu with tests skipped, to make sure the code stays sane w.r.t compilation and dart format.

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments as to why tests are skipped would be nice.

@domesticmouse
Copy link
Contributor Author

Comments as to why tests are skipped would be nice.

Created (and linked) flutter/flutter#171361

@domesticmouse domesticmouse added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 30, 2025
@auto-submit auto-submit bot merged commit dc096e3 into flutter:main Jun 30, 2025
10 checks passed
@domesticmouse domesticmouse deleted the enable-intro_flutter_gpu_attempt_2 branch June 30, 2025 08:39
domesticmouse added a commit that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants